On Wed, Oct 02, 2019 at 11:06:43AM -0700, Linus Torvalds wrote: > On Wed, Oct 2, 2019 at 6:48 AM Thomas Hellström (VMware) > <thomas_os@xxxxxxxxxxxx> wrote: > > > > From: Thomas Hellstrom <thellstrom@xxxxxxxxxx> > > > > Add two utilities to a) write-protect and b) clean all ptes pointing into > > a range of an address space. [...] > Yes, it's a bit more typing. But I really think > "clean_mapping_dirty_pages()" is just not only more in line with the > mm naming, I think it's a lot more legible and understandable than > "as_dirty_clean()", which just makes me go "what the heck does that > function do?" > > And I really think it needs more than just "as" -> "mapping". > "mapping_dirty_clean()" still makes me go "what?" in a way that > "clean_mapping_dirty_pages()" does not. One name reads as a series or > random words, the other reads as a "this is what the function does". I'd suggest clean_mapping_pages() -- a function which does that would naturally skip the non-dirty pages, and that doesn't need to be in the function name.
