On Fri, 13 May 2011 01:47:47 -0700 Greg Thelen <gthelen@xxxxxxxxxx> wrote: > Add writeback_control fields to differentiate between bdi-wide and > per-cgroup writeback. Cgroup writeback is also able to differentiate > between writing inodes isolated to a particular cgroup and inodes shared > by multiple cgroups. > > Signed-off-by: Greg Thelen <gthelen@xxxxxxxxxx> Personally, I want to see new flags with their usage in a patch... > --- > include/linux/writeback.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/include/linux/writeback.h b/include/linux/writeback.h > index d10d133..4f5c0d2 100644 > --- a/include/linux/writeback.h > +++ b/include/linux/writeback.h > @@ -47,6 +47,8 @@ struct writeback_control { > unsigned for_reclaim:1; /* Invoked from the page allocator */ > unsigned range_cyclic:1; /* range_start is cyclic */ > unsigned more_io:1; /* more io to be dispatched */ > + unsigned for_cgroup:1; /* enable cgroup writeback */ > + unsigned shared_inodes:1; /* write inodes spanning cgroups */ > }; If shared_inode is really rare case...we don't need to have this shared_inodes flag and do writeback shared_inode always.....No ? Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>