On Thu 12-05-11 16:53:53, Johannes Weiner wrote: > If the memcg reclaim code detects the target memcg below its limit it > exits and returns a guaranteed non-zero value so that the charge is > retried. > > Nowadays, the charge side checks the memcg limit itself and does not > rely on this non-zero return value trick. > > This patch removes it. The reclaim code will now always return the > true number of pages it reclaimed on its own. > > Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx> Makes sense Reviewed-by: Michal Hocko <mhocko@xxxxxxx> > --- > mm/memcontrol.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 010f916..bf5ab87 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1503,7 +1503,7 @@ static int mem_cgroup_hierarchical_reclaim(struct mem_cgroup *root_mem, > if (!res_counter_soft_limit_excess(&root_mem->res)) > return total; > } else if (mem_cgroup_margin(root_mem)) > - return 1 + total; > + return total; > } > return total; > } > -- > 1.7.5.1 > -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>