On Thu, May 12, 2011 at 12:19:45PM -0700, Ying Han wrote: > On Thu, May 12, 2011 at 7:53 AM, Johannes Weiner <hannes@xxxxxxxxxxx> wrote: > > > A page charged to a memcg is linked to a lru list specific to that > > memcg. At the same time, traditional global reclaim is obvlivious to > > memcgs, and all the pages are also linked to a global per-zone list. > > > > This patch changes traditional global reclaim to iterate over all > > existing memcgs, so that it no longer relies on the global list being > > present. > > > > > This is one step forward in integrating memcg code better into the > > rest of memory management. It is also a prerequisite to get rid > > of the global per-zone lru lists. > > > Sorry If i misunderstood something here. I assume this patch has not > much to do with the global soft_limit reclaim, but only allow the > system only scan per-memcg lru under global memory pressure. I see you found 6/6 in the meantime :) Did it answer your question? > > The algorithm implemented in this patch is very naive. For each zone > > scanned at each priority level, it iterates over all existing memcgs > > and considers them for scanning. > > > > This is just a prototype and I did not optimize it yet because I am > > unsure about the maximum number of memcgs that still constitute a sane > > configuration in comparison to the machine size. > > So we also scan memcg which has no page allocated on this zone? I > will read the following patch in case i missed something here :) The old hierarchy walk skipped a memcg if it had no local pages at all. I thought this was a rather unlikely situation and ripped it out. It will not loop persistently over a specific memcg and node combination, like soft limit reclaim does at the moment. Since this is much deeper integrated in memory reclaim now, it benefits from all the existing mechanisms and will calculate the scan target based on the number of lru pages on memcg->zone->lru, and do nothing if there are no pages there. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>