Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> writes: > On Tue, 17 Sep 2019 21:01:29 +0530 "Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxxxxx> wrote: > >> vmem_altmap_offset() adjust the section aligned base_pfn offset. >> So we need to make sure we account for the same when computing base_pfn. >> >> ie, for altmap_valid case, our pfn_first should be: >> >> pfn_first = altmap->base_pfn + vmem_altmap_offset(altmap); > > What are the user-visible runtime effects of this change? This was found by code inspection. If the pmem region is not correctly section aligned we can skip pfns while iterating device pfn using for_each_device_pfn(pfn, pgmap) I still would want Dan to ack the change though. -aneesh