On Tue, Sep 17, 2019 at 04:35:02PM -0700, Sukadev Bhattiprolu wrote: > > > +unsigned long kvmppc_h_svm_init_done(struct kvm *kvm) > > +{ > > + if (!(kvm->arch.secure_guest & KVMPPC_SECURE_INIT_START)) > > Minor: Should we also check if KVMPPC_SECURE_INIT_DONE is set here (since > both can be set)? You imply that we can check if more H_SVM_INIT_DONE calls are issued after first such call? Currently we just set the KVMPPC_SECURE_INIT_DONE bit again. Regards, Bharata.