On 07.09.19 19:25, Alexander Duyck wrote: > From: Alexander Duyck <alexander.h.duyck@xxxxxxxxxxxxxxx> > > Move the static definition for things such as HUGETLB_PAGE_ORDER out of > asm/pgtable.h and place it in page-defs.h. By doing this the includes > become much easier to deal with as currently arm64 is the only architecture > that didn't include this definition in the asm/page.h file or a file > included by it. > > It also makes logical sense as PAGE_SHIFT was already defined in > page-defs.h so now we also have HPAGE_SHIFT defined there as well. > > Signed-off-by: Alexander Duyck <alexander.h.duyck@xxxxxxxxxxxxxxx> > --- > arch/arm64/include/asm/page-def.h | 9 +++++++++ > arch/arm64/include/asm/pgtable.h | 9 --------- > 2 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/arch/arm64/include/asm/page-def.h b/arch/arm64/include/asm/page-def.h > index f99d48ecbeef..1c5b079e2482 100644 > --- a/arch/arm64/include/asm/page-def.h > +++ b/arch/arm64/include/asm/page-def.h > @@ -20,4 +20,13 @@ > #define CONT_SIZE (_AC(1, UL) << (CONT_SHIFT + PAGE_SHIFT)) > #define CONT_MASK (~(CONT_SIZE-1)) > > +/* > + * Hugetlb definitions. > + */ > +#define HUGE_MAX_HSTATE 4 > +#define HPAGE_SHIFT PMD_SHIFT > +#define HPAGE_SIZE (_AC(1, UL) << HPAGE_SHIFT) > +#define HPAGE_MASK (~(HPAGE_SIZE - 1)) > +#define HUGETLB_PAGE_ORDER (HPAGE_SHIFT - PAGE_SHIFT) > + I wonder if you should initially limit "config PAGE_REPORTING" to x86 only and unlock it for the other targets once we actually test it there. Or did you test PAGE_REPORTING on other architectures as well? -- Thanks, David / dhildenb
