On Fri, Sep 6, 2019 at 11:17 AM James Morse <james.morse@xxxxxxx> wrote: > > Hi Pavel, > > On 21/08/2019 19:31, Pavel Tatashin wrote: > > create_safe_exec_page() allocates a safe page and maps it at a > > specific location, also this function returns the physical address > > of newly allocated page. > > > > The destination VA, and PA are specified in arguments: dst_addr, > > phys_dst_addr > > > > However, within the function it uses "dst" which has unsigned long > > type, but is actually a pointers in the current virtual space. This > > is confusing to read. > > The type? There are plenty of places in the kernel that an unsigned-long is actually a > pointer. This isn't unusual. > > > > Rename dst to more appropriate page (page that is created), and also > > change its time to "void *" > > If you think its clearer, > Reviewed-by: James Morse <james.morse@xxxxxxx> Thank you for your review. Pasha
