Re: [PATCH v3 03/17] arm64, hibernate: remove gotos in create_safe_exec_page

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>
Subject: Re: [PATCH v3 03/17] arm64, hibernate: remove gotos in create_safe_exec_page
From: James Morse <james.morse@xxxxxxx>
Date: Fri, 6 Sep 2019 16:17:33 +0100
Cc: jmorris@xxxxxxxxx, sashal@xxxxxxxxxx, ebiederm@xxxxxxxxxxxx, kexec@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, corbet@xxxxxxx, catalin.marinas@xxxxxxx, will@xxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, marc.zyngier@xxxxxxx, vladimir.murzin@xxxxxxx, matthias.bgg@xxxxxxxxx, bhsharma@xxxxxxxxxx, linux-mm@xxxxxxxxx, mark.rutland@xxxxxxx
In-reply-to: <20190821183204.23576-4-pasha.tatashin@soleen.com>
References: <20190821183204.23576-1-pasha.tatashin@soleen.com> <20190821183204.23576-4-pasha.tatashin@soleen.com>
User-agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2

Hi Pavel,

On 21/08/2019 19:31, Pavel Tatashin wrote:
> Usually, gotos are used to handle cleanup after exception, but
> in case of create_safe_exec_page there are no clean-ups. So,
> simply return the errors directly.

Reviewed-by: James Morse <james.morse@xxxxxxx>


Thanks,

James

Follow-Ups:
- Re: [PATCH v3 03/17] arm64, hibernate: remove gotos in create_safe_exec_page
  - From: Pavel Tatashin

References:
- [PATCH v3 00/17] arm64: MMU enabled kexec relocation
  - From: Pavel Tatashin
- [PATCH v3 03/17] arm64, hibernate: remove gotos in create_safe_exec_page
  - From: Pavel Tatashin

Prev by Date: Re: [PATCH v3 02/17] arm64, hibernate: use get_safe_page directly
Next by Date: Re: [PATCH v3 04/17] arm64, hibernate: rename dst to page in create_safe_exec_page
Previous by thread: [PATCH v3 03/17] arm64, hibernate: remove gotos in create_safe_exec_page
Next by thread: Re: [PATCH v3 03/17] arm64, hibernate: remove gotos in create_safe_exec_page
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]