> On Sep 3, 2019, at 1:15 PM, Michal Hocko <mhocko@xxxxxxxxxx> wrote: > > Then I would suggest mentioning all this in the changelog so that the > overall intention is clear. It is also up to you fs developers to find a > consensus on how to move forward. I have brought that up mostly because > I really hate seeing new config options added due to shortage of > confidence in the code. That really smells like working around standard > code quality inclusion process. I do mention a good deal of this in the blurb in part [0/2] of the patch, though I don't cover the readpage/readpages() debate. Ideally readpage() should do just that, read a page, based on the size of the page passed, and not assume "page" means "PAGESIZE." I can also make the "help" text for the option more descriptive if desired. Thanks for your comments!
