On Thu, Aug 29, 2019 at 9:18 AM Michal Hocko <mhocko@xxxxxxxxxx> wrote: > > On Thu 29-08-19 08:03:19, Edward Chron wrote: > > On Thu, Aug 29, 2019 at 4:56 AM Michal Hocko <mhocko@xxxxxxxxxx> wrote: > [...] > > > Or simply provide a hook with the oom_control to be called to report > > > without replacing the whole oom killer behavior. That is not necessary. > > > > For very simple addition, to add a line of output this works. > > Why would a hook be limited to small stuff? It could be larger but the few items we added were just a line or two of output. The vmalloc, slabs and processes can print many entries so we added a control for those. > > > It would still be nice to address the fact the existing OOM Report prints > > all of the user processes or none. It would be nice to add some control > > for that. That's what we did. > > TBH, I am not really convinced partial taks list is desirable nor easy > to configure. What is the criterion? oom_score (with potentially unstable > metric)? Rss? Something else? We used an estimate of the memory footprint of the process: rss, swap pages and page table pages. > -- > Michal Hocko > SUSE Labs
