On Thu, Aug 22, 2019 at 03:56:17PM +0530, Bharata B Rao wrote: > + /* > + * TODO: Handle KVM_MR_MOVE > + */ > + if (change == KVM_MR_CREATE) { > + uv_register_mem_slot(kvm->arch.lpid, > + new->base_gfn << PAGE_SHIFT, > + new->npages * PAGE_SIZE, > + 0, new->id); > + } else if (change == KVM_MR_DELETE) > + uv_unregister_mem_slot(kvm->arch.lpid, old->id); > } In preparation for the KVM_MR_MOVE addition just using a switch statement here from the very beginning might make the code a little nicer to read.