On 8/27/19 7:19 AM, Jan Kara wrote:
On Tue 20-08-19 11:06:48, Mark Salyzyn wrote:
diff --git a/Documentation/filesystems/Locking b/Documentation/filesystems/Locking
index 204dd3ea36bb..e2687f21c7d6 100644
--- a/Documentation/filesystems/Locking
+++ b/Documentation/filesystems/Locking
@@ -101,12 +101,10 @@ of the locking scheme for directory operations.
----------------------- xattr_handler operations -----------------------
prototypes:
bool (*list)(struct dentry *dentry);
- int (*get)(const struct xattr_handler *handler, struct dentry *dentry,
- struct inode *inode, const char *name, void *buffer,
- size_t size);
- int (*set)(const struct xattr_handler *handler, struct dentry *dentry,
- struct inode *inode, const char *name, const void *buffer,
- size_t size, int flags);
+ int (*get)(const struct xattr_handler *handler,
+ struct xattr_gs_flags);
+ int (*set)(const struct xattr_handler *handler,
+ struct xattr_gs_flags);
The prototype here is really "struct xattr_gs_flags *args", isn't it?
Otherwise feel free to add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
for the ext2, ext4, ocfs2, reiserfs, and the generic fs/* bits.
Honza
<oops> Thanks and good catch, will respin with a fix to the
documentation shortly.
-- Mark