Hello Bharata, I have just a couple of small comments. Bharata B Rao <bharata@xxxxxxxxxxxxx> writes: > +/* > + * Get a free device PFN from the pool > + * > + * Called when a normal page is moved to secure memory (UV_PAGE_IN). Device > + * PFN will be used to keep track of the secure page on HV side. > + * > + * @rmap here is the slot in the rmap array that corresponds to @gpa. > + * Thus a non-zero rmap entry indicates that the corresonding guest Typo: corresponding > +static u64 kvmppc_get_secmem_size(void) > +{ > + struct device_node *np; > + int i, len; > + const __be32 *prop; > + u64 size = 0; > + > + np = of_find_node_by_path("/ibm,ultravisor/ibm,uv-firmware"); > + if (!np) > + goto out; I believe that in general we try to avoid hard-coding the path when a node is accessed and searched instead via its compatible property. -- Thiago Jung Bauermann IBM Linux Technology Center