On Sun, Aug 18, 2019 at 2:12 AM Christoph Hellwig <hch@xxxxxx> wrote: > > The dev field in struct dev_pagemap is only used to print dev_name in > two places, which are at best nice to have. Just remove the field > and thus the name in those two messages. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx> Needs the below as well. /me goes to check if he ever merged the fix to make the unit test stuff get built by default with COMPILE_TEST [1]. Argh! Nope, didn't submit it for 5.3-rc1, sorry for the thrash. You can otherwise add: Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx> [1]: https://lore.kernel.org/lkml/156097224232.1086847.9463861924683372741.stgit@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ --- diff --git a/tools/testing/nvdimm/test/iomap.c b/tools/testing/nvdimm/test/iomap.c index cd040b5abffe..3f55f2f99112 100644 --- a/tools/testing/nvdimm/test/iomap.c +++ b/tools/testing/nvdimm/test/iomap.c @@ -132,7 +132,6 @@ void *__wrap_devm_memremap_pages(struct device *dev, struct dev_pagemap *pgmap) if (!nfit_res) return devm_memremap_pages(dev, pgmap); - pgmap->dev = dev; if (!pgmap->ref) { if (pgmap->ops && (pgmap->ops->kill || pgmap->ops->cleanup)) return ERR_PTR(-EINVAL);
