> static int numa_maps_open(struct inode *inode, struct file *file) > { > - return do_maps_open(inode, file, &proc_pid_numa_maps_op); > + struct numa_maps_private *priv; > + int ret = -ENOMEM; > + priv = kzalloc(sizeof(*priv), GFP_KERNEL); > + if (priv) { > + priv->proc_maps.pid = proc_pid(inode); > + ret = seq_open(file, &proc_pid_numa_maps_op); > + if (!ret) { > + struct seq_file *m = file->private_data; > + m->private = priv; > + } else { > + kfree(priv); > + } > + } > + return ret; > } Looks good to me. Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>