> Moving show_numa_map() from mempolicy.c to task_mmu.c solves several > issues. > > - Having the show() operation "miles away" from the corresponding > seq_file iteration operations is a maintenance burden. > > - The need to export ad hoc info like struct proc_maps_private is > eliminated. > > - The implementation of show_numa_map() can be improved in a simple > manner by cooperating with the other seq_file operations (start, > stop, etc) -- something that would be messy to do without this > change. > > Signed-off-by: Stephen Wilson <wilsons@xxxxxxxx> > --- > fs/proc/task_mmu.c | 170 +++++++++++++++++++++++++++++++++++++++++++++++++++- > mm/mempolicy.c | 168 --------------------------------------------------- > 2 files changed, 168 insertions(+), 170 deletions(-) Looks good to me. Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>