On Tue, May 03, 2011 at 01:57:44PM -0700, akpm@xxxxxxxxxxxxxxxxxxxx wrote: > struct backing_dev_info *old = inode->i_data.backing_dev_info; > > - if (dst == old) > + if (dst == old) /* deadlock avoidance */ That's not an overly useful comment. It should be a proper block coment documentation how that we could ever end up with the same bdi as destination and source. Which is something I wanted to ask Hugh anyway - do you have traces explaining how this happens for you? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>