On 7/31/19 6:23 AM, Vlastimil Babka wrote: > On 7/25/19 7:15 PM, Mike Kravetz wrote: >> On 7/25/19 1:13 AM, Mel Gorman wrote: >>> On Wed, Jul 24, 2019 at 10:50:14AM -0700, Mike Kravetz wrote: >>> >>> set_max_huge_pages can fail the NODEMASK_ALLOC() alloc which you handle >>> *but* in the event of an allocation failure this bug can silently recur. >>> An informational message might be justified in that case in case the >>> stall should recur with no hint as to why. >> >> Right. >> Perhaps a NODEMASK_ALLOC() failure should just result in a quick exit/error. >> If we can't allocate a node mask, it is unlikely we will be able to allocate >> a/any huge pages. And, the system must be extremely low on memory and there >> are likely other bigger issues. > > Agreed. But I would perhaps drop __GFP_NORETRY from the mask allocation > as that can fail for transient conditions. Thanks, I was unsure if adding __GFP_NORETRY would be a good idea. -- Mike Kravetz
