On Wed 31-07-19 15:37:56, David Hildenbrand wrote: [...] > The other extreme I saw: People dropping locks because they think they > can be smart but end up making developers debug crashes for months (I am > not lying). Any lock removal should be accompanied with an explanation that is to be a subject of the review. Sure people can make mistakes but there is no way to around it I can see. > As I want to move on with this patch and have other stuff to work on, I > will adjust the comment you gave and add that instead of the lock. Thanks! -- Michal Hocko SUSE Labs