On Wed 31-07-19 14:22:13, David Hildenbrand wrote: > Each memory block spans the same amount of sections/pages/bytes. The size > is determined before the first memory block is created. No need to store > what we can easily calculate - and the calculations even look simpler now. While this cleanup helps a bit, I am not sure this is really worth bothering. I guess we can agree when I say that the memblock interface is suboptimal (to put it mildly). Shouldn't we strive for making it a real hotplug API in the future? What do I mean by that? Why should be any memblock fixed in size? Shouldn't we have use hotplugable units instead (aka pfn range that userspace can work with sensibly)? Do we know of any existing userspace that would depend on the current single section res. 2GB sized memblocks? All that being said, I do not oppose to the patch but can we start thinking about the underlying memblock limitations rather than micro cleanups? -- Michal Hocko SUSE Labs
