On Fri, Jul 26, 2019 at 02:16:20PM +0300, Konstantin Khlebnikov wrote: > On 26.07.2019 3:06, Joel Fernandes wrote: > > On Thu, Jul 25, 2019 at 11:15:53AM +0300, Konstantin Khlebnikov wrote: > > [snip] > > > > > > Thanks for bringing up the swapping corner case.. Perhaps we can improve > > > > > > the heap profiler to detect this by looking at bits 0-4 in pagemap. While it > > > > > > > > > > Yeb, that could work but it could add overhead again what you want to remove? > > > > > Even, userspace should keep metadata to identify that page was already swapped > > > > > in last period or newly swapped in new period. > > > > > > > > Yep. > > > Between samples page could be read from swap and swapped out back multiple times. > > > For tracking this swap ptes could be marked with idle bit too. > > > I believe it's not so hard to find free bit for this. > > > > > > Refault\swapout will automatically clear this bit in pte even if > > > page goes nowhere stays if swap-cache. > > > > Could you clarify more about your idea? Do you mean swapout will clear the new > > idle swap-pte bit if the page was accessed just before the swapout? > > > Instead, I thought of using is_swap_pte() to detect if the PTE belong to a > > page that was swapped. And if so, then assume the page was idle. Sure we > > would miss data that the page was accessed before the swap out in the > > sampling window, however if the page was swapped out, then it is likely idle > > anyway. > > > I mean page might be in swap when you mark pages idle and > then been accessed and swapped back before second pass. > > I propose marking swap pte with idle bit which will be automatically > cleared by following swapin/swapout pair: > > page alloc -> install page pte > page swapout -> install swap entry in pte > mark vm idle -> set swap-idle bit in swap pte > access/swapin -> install page pte (clear page idle if set) > page swapout -> install swap entry in pte (without swap idle bit) > scan vm idle -> see swap entry without idle bit -> page has been accessed since marking idle > > One bit in pte is enough for tracking. This does not needs any propagation for > idle bits between page and swap, or marking pages as idle in swap cache. Ok I see the case you are referring to now. This can be a follow-up patch to address the case, because.. the limitation you mentioned is also something inherrent in the (traditional) physical page_idle tracking if that were used. The reason being, after swapping, the PTE is not mapped to any page so there is nothing to mark as idle. So if the page gets swapped out and in in the meanwhile, then you would run into the same issue. But yes, we should certainly address it in the future. I just want to keep things simple at the moment. I will make a note about your suggestion but you are welcomed to write a patch for it on top of my patch. I am about to send another revision shortly for futhre review. thanks, - Joel
