> On Jul 24, 2019, at 2:17 AM, Oleg Nesterov <oleg@xxxxxxxxxx> wrote: > > On 07/24, Oleg Nesterov wrote: >> >> On 07/24, Song Liu wrote: >>> >>> This patch allows uprobe to use original page when possible (all uprobes >>> on the page are already removed). >> >> and only if the original page is already in the page cache and uptodate, >> right? >> >> another reason why I think unmap makes more sense... but I won't argue. > > but somehow I forgot we need to read the original page anyway to check > pages_identical(), so unmap is not really better, please forget. > Yeah, I was trying to explain this. :) Thanks for your feedbacks. Song
