On Wed, Jul 17, 2019 at 10:49 PM Christoph Hellwig <hch@xxxxxx> wrote: > > Hi Dan, > > was there any really good reason to have memremap.c in kernel/ back > when you started it? It seems to be pretty much tried into the mm > infrastructure, and I keep mistyping the path. Would you mind a simple > git-mv patch after -rc1 to move it to mm/ ? No complaints from me. It ended up there because it was originally just the common memremap implementation always built with CONFIG_HAS_IOMEM. Arguably we should have done this move right after commit 5981690ddb8f ("memremap: split devm_memremap_pages() and memremap() infrastructure").