On Sat, 6 Jul 2019, Salvatore Mesoraca wrote: > Creation of the S.A.R.A. cred blob management "API". > In order to allow S.A.R.A. to be stackable with other LSMs, it doesn't use > the "security" field of struct cred, instead it uses an ad hoc field named > security_sara. > This solution is probably not acceptable for upstream, so this part will > be modified as soon as the LSM stackable cred blob management will be > available. This description is out of date wrt cred blob sharing. > + if (sara_data_init()) { > + pr_crit("impossible to initialize creds.\n"); > + goto error; > + } > + > +int __init sara_data_init(void) > +{ > + security_add_hooks(data_hooks, ARRAY_SIZE(data_hooks), "sara"); > + return 0; > +} This can't fail so make it return void and simplify the caller. -- James Morris <jmorris@xxxxxxxxx>