Re: [PATCH] percpu: preemptless __per_cpu_counter_add

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey,

On Thu, Apr 28, 2011 at 09:52:35AM -0500, Christoph Lameter wrote:
> On Thu, 28 Apr 2011, Tejun Heo wrote:
> 
> > Eh?  Are you saying the above can't happen or the above doesn't
> > matter?
> 
> Its an artificial use case that does not reflect the realities on how
> these counters are typically used.

Gees, Christoph.  That is a test case to show the issue prominently,
which is what a test case is supposed to do.  What it means is that
_any_ update can trigger @batch deviation on _sum() regardless of its
frequency or concurrency level and that's the nastiness I've been
talking about over and over again.

For fast path, sure.  For slow path, I don't think so.  If the
tradeoff still doesn't make sense to you, I don't know how to persuade
you guys.  I'm not gonna take it.  You and Shaohua are welcome to go
over my head and send the changes to Andrew or Linus, but please keep
me cc'd so that I can voice my objection.

Thank you.

-- 
tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]