On Thu, Apr 28, 2011 at 04:23:31PM +0200, Tejun Heo wrote: > Such users then shouldn't use _sum() - maybe rename it to > _very_slow_sum() if you're concerned about misusage. percpu_counter() > is already used in filesystems to count free blocks and there are > times where atomic_t type accuracy is needed and _sum() achieves that. > The proposed changes break that. Why do I need to say this over and > over again? And I'm getting more and more frustrated. THIS IS SLOW PATH. If it's showing up on your profile, bump up @batch. It doesn't make any sense to micro optimize slow path at the cost of introducing such nastiness. Unless someone can show me such nastiness doesn't exist, I'm not gonna take this change. Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>