Can someone from linux-mm list please provide a feedback on this ? On 07/01/2019 02:58 PM, Chaitanya Kulkarni wrote: > This patch updates the block_dump documentation with respect to the > changes from the earlier patch for submit_bio(). Also we adjust rest of > the lines to fit with standaed format. > > Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx> > --- > Documentation/laptops/laptop-mode.txt | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/Documentation/laptops/laptop-mode.txt b/Documentation/laptops/laptop-mode.txt > index 1c707fc9b141..d4d72ed677c4 100644 > --- a/Documentation/laptops/laptop-mode.txt > +++ b/Documentation/laptops/laptop-mode.txt > @@ -101,14 +101,14 @@ a cache miss. The disk can then be spun down in the periods of inactivity. > > If you want to find out which process caused the disk to spin up, you can > gather information by setting the flag /proc/sys/vm/block_dump. When this flag > -is set, Linux reports all disk read and write operations that take place, and > -all block dirtyings done to files. This makes it possible to debug why a disk > -needs to spin up, and to increase battery life even more. The output of > -block_dump is written to the kernel output, and it can be retrieved using > -"dmesg". When you use block_dump and your kernel logging level also includes > -kernel debugging messages, you probably want to turn off klogd, otherwise > -the output of block_dump will be logged, causing disk activity that is not > -normally there. > +is set, Linux reports all disk I/O operations along with read and write > +operations that take place, and all block dirtyings done to files. This makes > +it possible to debug why a disk needs to spin up, and to increase battery life > +even more. The output of block_dump is written to the kernel output, and it can > +be retrieved using "dmesg". When you use block_dump and your kernel logging > +level also includes kernel debugging messages, you probably want to turn off > +klogd, otherwise the output of block_dump will be logged, causing disk activity > +that is not normally there. > > > Configuration >
