On 01/07/2019 10:27, Will Deacon wrote: > Hi Nick, > > On Sun, Jun 23, 2019 at 07:44:44PM +1000, Nicholas Piggin wrote: >> walk_page_range() is going to be allowed to walk page tables other than >> those of user space. For this it needs to know when it has reached a >> 'leaf' entry in the page tables. This information will be provided by the >> p?d_large() functions/macros. > > I can't remember whether or not I asked this before, but why not call > this macro p?d_leaf() if that's what it's identifying? "Large" and "huge" > are usually synonymous, so I find this naming needlessly confusing based > on this patch in isolation. Hi Will, You replied to my posting of this patch before[1], to which you said: > I've have thought p?d_leaf() might match better with your description > above, but I'm not going to quibble on naming. Have you changed your mind about quibbling? ;) Steve [1] https://lore.kernel.org/lkml/20190611153650.GB4324@xxxxxxxxxxxxxxxxxxxxxxxxx/
