On Wed 26-06-19 20:46:02, Tetsuo Handa wrote: > On 2019/06/26 19:47, Michal Hocko wrote: > > On Wed 26-06-19 19:19:20, Tetsuo Handa wrote: > >> Is "mempolicy_nodemask_intersects(tsk) returning true when tsk already > >> passed mpol_put_task_policy(tsk) in do_exit()" what we want? > >> > >> If tsk is an already exit()ed thread group leader, that thread group is > >> needlessly selected by the OOM killer because mpol_put_task_policy() > >> returns true? > > > > I am sorry but I do not really see how this is related to this > > particular patch. Are you suggesting that has_intersects_mems_allowed is > > racy? More racy now? > > I'm suspecting the correctness of has_intersects_mems_allowed(). THen this deserves an own email thread. Thanks! -- Michal Hocko SUSE Labs