On Wed 26-06-19 16:30:55, Alastair D'Silva wrote: > On Wed, 2019-06-26 at 08:23 +0200, Michal Hocko wrote: > > On Wed 26-06-19 16:11:22, Alastair D'Silva wrote: > > > From: Alastair D'Silva <alastair@xxxxxxxxxxx> > > > > > > By adding offset to memmap before passing it in to > > > clear_hwpoisoned_pages, > > > we hide a potentially null memmap from the null check inside > > > clear_hwpoisoned_pages. > > > > > > This patch passes the offset to clear_hwpoisoned_pages instead, > > > allowing > > > memmap to successfully peform it's null check. > > > > Same issue with the changelog as the previous patch (missing WHY). > > > > The first paragraph explains what the problem is with the existing code > (same applies to 1/3 too). Under what conditions that happens? Is this a theoretical problem or can you hit this by a (buggy) code? Please be much more specific. -- Michal Hocko SUSE Labs
