On Wed, Apr 27, 2011 at 5:03 PM, KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote: > On Wed, 27 Apr 2011 01:25:20 +0900 > Minchan Kim <minchan.kim@xxxxxxxxx> wrote: > >> In some __zone_reclaim case, we don't want to shrink mapped page. >> Nonetheless, we have isolated mapped page and re-add it into >> LRU's head. It's unnecessary CPU overhead and makes LRU churning. >> >> Of course, when we isolate the page, the page might be mapped but >> when we try to migrate the page, the page would be not mapped. >> So it could be migrated. But race is rare and although it happens, >> it's no big deal. >> >> Cc: Christoph Lameter <cl@xxxxxxxxx> >> Cc: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> >> Cc: Mel Gorman <mgorman@xxxxxxx> >> Cc: Rik van Riel <riel@xxxxxxxxxx> >> Cc: Andrea Arcangeli <aarcange@xxxxxxxxxx> >> Signed-off-by: Minchan Kim <minchan.kim@xxxxxxxxx> > > > Hmm, it seems mm/memcontrol.c::mem_cgroup_isolate_pages() should be updated, too. > > But it's okay you start from global LRU. Yes. That's exactly what I want. :) I am supposed to consider memcg after concept is approved. > > Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> Thanks fore the review, Kame. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>