On Thu, Jun 20, 2019 at 09:08:54AM +0200, Michal Hocko wrote: > On Thu 20-06-19 09:06:51, Minchan Kim wrote: > > On Wed, Jun 19, 2019 at 02:56:12PM +0200, Michal Hocko wrote: > [...] > > > Why cannot we reuse a large part of that code and differ essentially on > > > the reclaim target check and action? Have you considered to consolidate > > > the code to share as much as possible? Maybe that is easier said than > > > done because the devil is always in details... > > > > Yub, it was not pretty when I tried. Please see last patch in this > > patchset. > > That is bad because this code is quite subtle - especially the THP part > of it. I will be staring at the code some more. Maybe some > simplification pops out. Yeah, I couldn't come up with better idea. Actually, I wanted to be left. More suggestion to make simple/readable would be great.
