On Wed, 27 Apr 2011 01:25:19 +0900 Minchan Kim <minchan.kim@xxxxxxxxx> wrote: > In async mode, compaction doesn't migrate dirty or writeback pages. > So, it's meaningless to pick the page and re-add it to lru list. > > Of course, when we isolate the page in compaction, the page might > be dirty or writeback but when we try to migrate the page, the page > would be not dirty, writeback. So it could be migrated. But it's > very unlikely as isolate and migration cycle is much faster than > writeout. > > So, this patch helps cpu and prevent unnecessary LRU churning. > > Cc: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> > Cc: Mel Gorman <mgorman@xxxxxxx> > Cc: Rik van Riel <riel@xxxxxxxxxx> > Cc: Andrea Arcangeli <aarcange@xxxxxxxxxx> > Signed-off-by: Minchan Kim <minchan.kim@xxxxxxxxx> seems very nice to me. Thank you. Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>