On Tue 18-06-19 19:23:55, Tetsuo Handa wrote:
> Since commit bbbe48029720d2c6 ("mm, oom: remove 'prefer children over
> parent' heuristic") removed
>
> "%s: Kill process %d (%s) score %u or sacrifice child\n"
>
> line, oc->chosen_points is no longer used after select_bad_process().
Well spotted. I am still trying to understand how that was supposed to
work before that commit as oom_badness() already provides a normalized
value so we have normalized it for the second time. But that is largely
irrelevant for this patch.
> Signed-off-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
Acked-by: Michal Hocko <mhocko@xxxxxxxx>
Thanks!
> ---
> mm/oom_kill.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index 09a5116..789a1bc 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -380,8 +380,6 @@ static void select_bad_process(struct oom_control *oc)
> break;
> rcu_read_unlock();
> }
> -
> - oc->chosen_points = oc->chosen_points * 1000 / oc->totalpages;
> }
>
> static int dump_task(struct task_struct *p, void *arg)
> --
> 1.8.3.1
--
Michal Hocko
SUSE Labs
