> > > btw readahead page allocations are completely optional. They are OK to
> > > fail and in theory shall not trigger OOM on themselves. We may
> > > consider passing __GFP_NORETRY for readahead page allocations.
> >
> > Good idea, care to submit a patch?
>
> Here it is :)
>
> Thanks,
> Fengguang
> ---
> readahead: readahead page allocations is OK to fail
>
> Pass __GFP_NORETRY for readahead page allocations.
>
> readahead page allocations are completely optional. They are OK to
> fail and in particular shall not trigger OOM on themselves.
>
> Reported-by: Dave Young <hidave.darkstar@xxxxxxxxx>
> Signed-off-by: Wu Fengguang <fengguang.wu@xxxxxxxxx>
> ---
> include/linux/pagemap.h | 5 +++++
> mm/readahead.c | 2 +-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> --- linux-next.orig/include/linux/pagemap.h 2011-04-26 14:27:46.000000000 +0800
> +++ linux-next/include/linux/pagemap.h 2011-04-26 14:29:31.000000000 +0800
> @@ -219,6 +219,11 @@ static inline struct page *page_cache_al
> return __page_cache_alloc(mapping_gfp_mask(x)|__GFP_COLD);
> }
>
> +static inline struct page *page_cache_alloc_cold_noretry(struct address_space *x)
> +{
> + return __page_cache_alloc(mapping_gfp_mask(x)|__GFP_COLD|__GFP_NORETRY);
> +}
> +
> typedef int filler_t(void *, struct page *);
>
> extern struct page * find_get_page(struct address_space *mapping,
> --- linux-next.orig/mm/readahead.c 2011-04-26 14:27:02.000000000 +0800
> +++ linux-next/mm/readahead.c 2011-04-26 14:27:24.000000000 +0800
> @@ -180,7 +180,7 @@ __do_page_cache_readahead(struct address
> if (page)
> continue;
>
> - page = page_cache_alloc_cold(mapping);
> + page = page_cache_alloc_cold_noretry(mapping);
> if (!page)
> break;
> page->index = page_offset;
I like this patch.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>