On Thu, Jun 06, 2019 at 11:52:13AM -0400, Jerome Glisse wrote: > On Thu, Jun 06, 2019 at 12:41:29PM -0300, Jason Gunthorpe wrote: > > On Thu, Jun 06, 2019 at 10:27:43AM -0400, Jerome Glisse wrote: > > > On Thu, Jun 06, 2019 at 11:16:44AM -0300, Jason Gunthorpe wrote: > > > > On Mon, May 06, 2019 at 04:29:39PM -0700, rcampbell@xxxxxxxxxx wrote: > > > > > From: Ralph Campbell <rcampbell@xxxxxxxxxx> > > > > > > > > > > There are no functional changes, just some coding style clean ups and > > > > > minor comment changes. > > > > > > > > > > Signed-off-by: Ralph Campbell <rcampbell@xxxxxxxxxx> > > > > > Reviewed-by: Jérôme Glisse <jglisse@xxxxxxxxxx> > > > > > Cc: John Hubbard <jhubbard@xxxxxxxxxx> > > > > > Cc: Ira Weiny <ira.weiny@xxxxxxxxx> > > > > > Cc: Dan Williams <dan.j.williams@xxxxxxxxx> > > > > > Cc: Arnd Bergmann <arnd@xxxxxxxx> > > > > > Cc: Balbir Singh <bsingharora@xxxxxxxxx> > > > > > Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > > > Cc: Matthew Wilcox <willy@xxxxxxxxxxxxx> > > > > > Cc: Souptick Joarder <jrdr.linux@xxxxxxxxx> > > > > > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > > > > include/linux/hmm.h | 71 +++++++++++++++++++++++---------------------- > > > > > mm/hmm.c | 51 ++++++++++++++++---------------- > > > > > 2 files changed, 62 insertions(+), 60 deletions(-) > > > > > > > > Applied to hmm.git, thanks > > > > > > Can you hold off, i was already collecting patches and we will > > > be stepping on each other toe ... for instance i had > > > > I'd really rather not, I have a lot of work to do for this cycle and > > this part needs to start to move forward now. I can't do everything > > last minute, sorry. > > > > The patches I picked up all look very safe to move ahead. > > I want to post all the patch you need to apply soon, it is really > painful because they are lot of different branches I've already handled everything in your hmm-5.3, so I don't think there is anything for you to do in that regard. Please double check though! If you have new patches please post them against something sensible (and put them in a git branch) and I can usually sort out 'git am' conflicts pretty quickly. > If you hold of i will be posting all the patches in one big set so > that you can apply all of them in one go and it will be a _lot_ > easier for me that way. You don't need to repost my patches, I can do that myself, but thanks for all the help getting them ready! Please respond to my v2 with more review's/ack's/changes/etc so the series can move toward being applied. > On process thing it would be easier if we ask Dave/Daniel to merge > hmm within drm this cycle. Yes, I expect we will do this - probably also to the AMD tree judging on things in -next. This is the entire point of running a shared tree. > Merging with Linus will break drm drivers and it seems easier to me > to fix all this within the drm tree. This is the normal process with a shared tree, we merge the tree *everywhere it is required* so all trees can run concurrently. I will *also* send it to Linus early so that Linus reviews the hmm patches in the HMM pull request, not in the DRM or RDMA pull request. This is best-practice when working across trees like this. Please just keep me up to date when things conflicting arise and we will work out the best solution. Reminder, I still need patches from you for: - Fix all the kconfig stuff for randconfig failures/etc - Enable ARM64 - Remove deprecated APIs from hmm.h Please send them ASAP so it can be tested. There shouldn't be any patches held back for 5.4 - send them all now. Thanks, Jason