On Thu 06-06-19 23:03:12, Yafang Shao wrote: > On Thu, Jun 6, 2019 at 10:44 PM Michal Hocko <mhocko@xxxxxxxx> wrote: > > > On Thu 06-06-19 22:18:41, Yafang Shao wrote: [...] > > > The reason I expose node reclaim details to userspace is because the user > > > can set node reclaim details now. > > > > Well, just because somebody _can_ enable it doesn't sound like a > > sufficient justification to expose even more implementation details of > > this feature. I am not really sure there is a strong reason to touch the > > code without a real usecase behind. > > > > > Got it. > > So should we fix the bugs in node reclaim path then? I am all for fixing bugs, I am just nervous to expose even more internal implementation details to the userspace if there is no _real_ usecase requiring it. -- Michal Hocko SUSE Labs