On Tue, 26 Apr 2011 11:19:22 +0800 Dave Young <hidave.darkstar@xxxxxxxxx> wrote: > On Tue, Apr 26, 2011 at 11:14 AM, KOSAKI Motohiro > <kosaki.motohiro@xxxxxxxxxxxxxx> wrote: > >> On Tue, Apr 26, 2011 at 10:57 AM, KOSAKI Motohiro > >> <kosaki.motohiro@xxxxxxxxxxxxxx> wrote: > >> >> oom_killer_disable should be a global switch, also fit for oom paths > >> >> other than __alloc_pages_slowpath > >> >> > >> >> Here add it to mem_cgroup_handle_oom and pagefault_out_of_memory as well. > >> > > >> > Can you please explain more? Why should? Now oom_killer_disabled is used > >> > only hibernation path. so, Why pagefault and memcg allocation will be happen? > >> > >> Indeed I'm using it in virtio balloon test, oom killer triggered when > >> memory pressure is high. > >> > >> literally oom_killer_disabled scope should be global, isn't it? > > > > ok. virtio baloon seems fair usage. if you add new usage of oom_killer_disabled > > into the patch description, I'll ack this one. > > Thanks, then I will resend the virtio balloon patch along with this. > Amount of free memory doesn't affect memory cgroup's OOM because it just works against the limit. So, the code for memcg isn't necessary. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>