On Tue, Jun 04, 2019 at 09:14:18PM -0700, Andrew Morton wrote: > On Tue, 4 Jun 2019 19:44:44 -0700 Roman Gushchin <guro@xxxxxx> wrote: > > > So instead of trying to find a maybe non-existing balance, let's do reparent > > the accounted slabs to the parent cgroup on cgroup removal. > > s/slabs/slab caches/. Take more care with the terminology, please... Slabs are effectively reparented too (what's most important, their references), but I agree, "slab caches" suits better here. > > > There is a bonus: currently we do release empty kmem_caches on cgroup > > removal, however all other are waiting for the releasing of the memory cgroup. > > These refactorings allow kmem_caches to be released as soon as they > > become inactive and free. > > Unclear. > > s/All other/releasing of all non-empty slab caches depends upon the releasing/ > > I think? > How about this? There is a bonus: currently we release all memcg kmem_caches all together with the memory cgroup itself. This patchset allows individual kmem_caches to be released as soon as they become inactive and free. -- Sorry, my bad, I was focused on patches, and didn't give enough attention to the cover letter. I hope to get some feedback from Vladimir, and then post a next version with these issues fixed. Thank you for looking into it! Roman
