> > The better approach is swap-token recognize memcg and behave clever? :) > > Ok, this makes sense for memcg case. Maybe I missed something on the > per-node balance_pgdat, where it seems it will blindly disable the > swap_token_mm if there is a one. That's design. 'disable' of disable_swap_token() mean blindly disable. The intention is, priority != 0: try to avoid swap storm priority == 0: allow thrashing. it's better than false positive oom. > Should I include this patch into the per-memcg kswapd patset? Nope. This is standalone patch. current memcg direct reclaim path has the same problem. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>