Hi Anshuman, On Thu, May 09, 2019 at 10:16:17AM +0530, Anshuman Khandual wrote: > Pgtable page address can be fetched with [pmd|pte]_offset_[kernel] if input > address is PMD_SIZE or PTE_SIZE aligned. Input address is now guaranteed to > be aligned, hence fetched pgtable page address is always correct. But using > 0UL as offset base address has been a standard practice across platforms. > It also makes more sense as it isolates pgtable page address computation > from input virtual address alignment. This does not change functionality. > > Signed-off-by: Anshuman Khandual <anshuman.khandual@xxxxxxx> > Cc: Catalin Marinas <catalin.marinas@xxxxxxx> > Cc: Will Deacon <will.deacon@xxxxxxx> > Cc: Mark Rutland <mark.rutland@xxxxxxx> > Cc: James Morse <james.morse@xxxxxxx> > Cc: Robin Murphy <robin.murphy@xxxxxxx> What's the plan with this small series? I didn't find a v5 (unless I deleted it by mistake). I can queue this patch through the arm64 tree or they can both go in via the mm tree. -- Catalin