> On May 30, 2019, at 5:20 AM, Kirill A. Shutemov <kirill@xxxxxxxxxxxxx> wrote: > > On Wed, May 29, 2019 at 02:20:49PM -0700, Song Liu wrote: >> After all uprobes are removed from the huge page (with PTE pgtable), it >> is possible to collapse the pmd and benefit from THP again. This patch >> does the collapse. > > I don't think it's right way to go. We should deferred it to khugepaged. > We need to teach khugepaged to deal with PTE-mapped compound page. > And uprobe should only kick khugepaged for a VMA. Maybe synchronously. > I guess that would be the same logic, but run in khugepaged? It doesn't have to be done synchronously. Let me try that Thanks, Song > -- > Kirill A. Shutemov
