> > > I'd prefer that we remove /proc/pid/comm entirely or at least prevent > > > writing to it unless CONFIG_EXPERT. > > > > Eeeh. That's probably going to be a tough sell, as I think there is > > wider interest in what it provides. Its useful for debugging > > applications not kernels, so I doubt folks will want to rebuild their > > kernel to try to analyze a java issue. > > > > So I'm well aware that there is the chance that you catch the race and > > read an incomplete/invalid comm (it was discussed at length when the > > change went in), but somewhere I've missed how that's causing actual > > problems. Other then just being "evil" and having the documented race, > > could you clarify what the issue is that your hitting? > > The problem is, there is no documented as well. Okay, I recognized you > introduced new locking rule for task->comm. But there is no documented > it. Thus, We have no way to review current callsites are correct or not. > Can you please do it? And, I have a question. Do you mean now task->comm > reader don't need task_lock() even if it is another thread? > > _if_ every task->comm reader have to realize it has a chance to read > incomplete/invalid comm, task_lock() doesn't makes any help. ping? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>