On Thu, 21 Apr 2011, James Bottomley wrote: > > Ok, it seems like there're two options for this release cycle: > > > > (1) merge the patch that enables CONFIG_NUMA for DISCONTIGMEM but only > > do so if CONFIG_SLUB is enabled to avoid the build error, or > > That's not an option without coming up with the rest of the numa > fixes ... we can't basically force all SMP systems to become UP. > > What build error, by the way? There's only a runtime panic caused by > slub. > If you enable CONFIG_NUMA for ARCH_DISCONTIGMEM_ENABLE on parisc, it results in the same build error that you identified in http://marc.info/?l=linux-parisc&m=130326773918005 at least on my hppa64 compiler. > > (2) disallow CONFIG_SLUB for parisc with DISCONTIGMEM. > > Well, that's this patch ... it will actually fix every architecture, not > just parisc. > > > > diff --git a/init/Kconfig b/init/Kconfig > > index 56240e7..a7ad8fb 100644 > > --- a/init/Kconfig > > +++ b/init/Kconfig > > @@ -1226,6 +1226,7 @@ config SLAB > > per cpu and per node queues. > > > > config SLUB > > + depends on BROKEN || NUMA || !DISCONTIGMEM > > bool "SLUB (Unqueued Allocator)" > > help > > SLUB is a slab allocator that minimizes cache line usage > > > I already sent it to linux-arch and there's been no dissent; there have > been a few "will that fix my slub bug?" type of responses. > I was concerned about tile because it actually got all this right by using N_NORMAL_MEMORY appropriately and it uses slub by default, but it always enables NUMA at the moment so this won't impact it. Acked-by: David Rientjes <rientjes@xxxxxxxxxx> I agree we can now defer "parisc: enable CONFIG_NUMA for DISCONTIGMEM and fix build errors" until parisc moves away from DISCONTIGMEM, its extracted away from CONFIG_NUMA, or the scheduler issues are debugged. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>