On 05/15/2019 03:16 PM, Will Deacon wrote: > On Wed, May 15, 2019 at 08:05:16AM +0530, Anshuman Khandual wrote: >> Virtual address alignment is essential in ensuring correct clearing for all >> intermediate level pgtable entries and freeing associated pgtable pages. An >> unaligned address can end up randomly freeing pgtable page that potentially >> still contains valid mappings. Hence also check it's alignment along with >> existing phys_addr check. >> >> Signed-off-by: Anshuman Khandual <anshuman.khandual@xxxxxxx> >> Cc: Toshi Kani <toshi.kani@xxxxxxx> >> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> >> Cc: Will Deacon <will.deacon@xxxxxxx> >> Cc: Chintan Pandya <cpandya@xxxxxxxxxxxxxx> >> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> >> Cc: Catalin Marinas <catalin.marinas@xxxxxxx> >> --- >> Changes in V4: >> >> - Added similar check for ioremap_try_huge_p4d() as per Toshi Kani > > Sorry to be a pain, but in future please can you just resend the entire > series as a v4 (after giving it a few days for any other comments to come > in) if you make an update? It's a bit fiddly tracking which replies to which > individual patches need to be picked up, although I'm sure this varies > between maintainers. I wondered for some time about both the ways before landing on this side as it was pretty minor change. I understand the concern and will follow the suggestion next time around. If this one requires further update, will make it V5 and carry the change logs from here. > > No need to do anything this time, but just a small ask for future patches. Sure will do.
