On Fri, May 10, 2019 at 02:49:00PM -0400, Daniel Jordan wrote: > On Fri, May 10, 2019 at 12:36:48PM +0000, Bruce ZHANG wrote: > > The "Free pages count per migrate type at order" are shown with the > > order from 0 ~ (MAX_ORDER-1), while "Page block order" just print > > pageblock_order. If the macro CONFIG_HUGETLB_PAGE is defined, the > > pageblock_order may not be equal to (MAX_ORDER-1). > > All of this is true, but why do you think it's wrong? > Indeed, why is this wrong? > It makes sense that "Page block order" corresponds to pageblock_order, > regardless of whether pageblock_order == MAX_ORDER-1. > Page block order is related to the PMD huge page size, it's not directly related to MAX_ORDER other than MAX_ORDER is larger than pageblock_order. > Cc Mel, who added these two lines. > > > Signed-off-by: Zhang Bo <bo.zhang@xxxxxxx> What's there is correct so unless there is a great explanation as to why it should be different; Naked-by: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx> -- Mel Gorman SUSE Labs
