On Fri, May 10, 2019 at 9:32 AM Elliott, Robert (Servers) <elliott@xxxxxxx> wrote: > > > > > -----Original Message----- > > From: Linux-nvdimm <linux-nvdimm-bounces@xxxxxxxxxxxx> On Behalf Of > > Larry Bassel > > Sent: Thursday, May 09, 2019 11:06 AM > > Subject: [PATCH, RFC 1/2] Add config option to enable FS/DAX PMD > > sharing > > > > If enabled, sharing of FS/DAX PMDs will be attempted. > > > ... > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > ... > > > > +config MAY_SHARE_FSDAX_PMD > > +def_bool y > > + > > Is a config option really necessary - is there any reason to > not choose to do this? Agree. Either the arch implementation supports it or it doesn't, I don't see a need for any further configuration flexibility. Seems ARCH_WANT_HUGE_PMD_SHARE should be renamed ARCH_HAS_HUGE_PMD_SHARE and then auto-enable it.