On Tue, 7 May 2019 13:02:08 -0400 Sasha Levin <sashal@xxxxxxxxxx> wrote: > On Tue, May 07, 2019 at 09:50:50AM -0700, Linus Torvalds wrote: > >On Tue, May 7, 2019 at 9:31 AM Alexander Duyck > ><alexander.duyck@xxxxxxxxx> wrote: > >> > >> Wasn't this patch reverted in Linus's tree for causing a regression on > >> some platforms? If so I'm not sure we should pull this in as a > >> candidate for stable should we, or am I missing something? > > > >Good catch. It was reverted in commit 4aa9fc2a435a ("Revert "mm, > >memory_hotplug: initialize struct pages for the full memory > >section""). > > > >We ended up with efad4e475c31 ("mm, memory_hotplug: > >is_mem_section_removable do not pass the end of a zone") instead (and > >possibly others - this was just from looking for commit messages that > >mentioned that reverted commit). > > I got it wrong then. I'll fix it up and get efad4e475c31 in instead. There were two commits replacing the reverted commit, fixing is_mem_section_removable() and test_pages_in_a_zone() respectively: commit 24feb47c5fa5 ("mm, memory_hotplug: test_pages_in_a_zone do not pass the end of zone") commit efad4e475c31 ("mm, memory_hotplug: is_mem_section_removable do not pass the end of a zone")