On Fri, May 03, 2019 at 01:16:30PM -0700, Daniel Jordan wrote: > locked_vm accounting is done roughly the same way in five places, so > unify them in a helper. Standardize the debug prints, which vary > slightly. Error codes stay the same, so user-visible behavior does too. > > Signed-off-by: Daniel Jordan <daniel.m.jordan@xxxxxxxxxx> > Cc: Alan Tull <atull@xxxxxxxxxx> > Cc: Alexey Kardashevskiy <aik@xxxxxxxxx> > Cc: Alex Williamson <alex.williamson@xxxxxxxxxx> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> > Cc: Christoph Lameter <cl@xxxxxxxxx> > Cc: Christophe Leroy <christophe.leroy@xxxxxx> > Cc: Davidlohr Bueso <dave@xxxxxxxxxxxx> > Cc: Jason Gunthorpe <jgg@xxxxxxxxxxxx> > Cc: Mark Rutland <mark.rutland@xxxxxxx> > Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx> > Cc: Moritz Fischer <mdf@xxxxxxxxxx> > Cc: Paul Mackerras <paulus@xxxxxxxxxx> > Cc: Steve Sistare <steven.sistare@xxxxxxxxxx> > Cc: Wu Hao <hao.wu@xxxxxxxxx> > Cc: linux-mm@xxxxxxxxx > Cc: kvm@xxxxxxxxxxxxxxx > Cc: kvm-ppc@xxxxxxxxxxxxxxx > Cc: linuxppc-dev@xxxxxxxxxxxxxxxx > Cc: linux-fpga@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > > Based on v5.1-rc7. Tested with the vfio type1 driver. Any feedback > welcome. > > Andrew, this one patch replaces these six from [1]: > > mm-change-locked_vms-type-from-unsigned-long-to-atomic64_t.patch > vfio-type1-drop-mmap_sem-now-that-locked_vm-is-atomic.patch > vfio-spapr_tce-drop-mmap_sem-now-that-locked_vm-is-atomic.patch > fpga-dlf-afu-drop-mmap_sem-now-that-locked_vm-is-atomic.patch > kvm-book3s-drop-mmap_sem-now-that-locked_vm-is-atomic.patch > powerpc-mmu-drop-mmap_sem-now-that-locked_vm-is-atomic.patch > > That series converts locked_vm to an atomic, but on closer inspection causes at > least one accounting race in mremap, and fixing it just for this type > conversion came with too much ugly in the core mm to justify, especially when > the right long-term fix is making these drivers use pinned_vm instead. Did we ever decide what to do here? Should all these drivers be switched to pinned_vm anyhow? Jason
